Extracted abstract for redundant Host & URI text matchers #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
approved these changes
Aug 28, 2024
konradoboza
reviewed
Aug 28, 2024
src/lib/MVC/Symfony/SiteAccess/Matcher/PrefixSuffixBasedTextMatcher.php
Outdated
Show resolved
Hide resolved
src/lib/MVC/Symfony/SiteAccess/Matcher/PrefixSuffixBasedTextMatcher.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
Aug 28, 2024
src/lib/MVC/Symfony/SiteAccess/Matcher/PrefixSuffixBasedTextMatcher.php
Outdated
Show resolved
Hide resolved
Co-Authored-By: Adam Wójs <[email protected]> Co-Authored-By: Konrad Oboza <[email protected]>
|
konradoboza
approved these changes
Aug 28, 2024
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
For more details see #424 Key changes: * Extracted abstract `AffixBasedTextMatcher` for redundant Host & URI text matchers * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Konrad Oboza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR addresses code redundancy between
URITextandHostTextMatchers. Big portion of the code was identical. Found by SonarCloud for #385.For QA:
Regression build should be enough (ibexa/commerce#1009).